lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 26 Apr 2016 16:25:17 +0200 From: Jiri Pirko <jiri@...nulli.us> To: Leon Romanovsky <leon@...nel.org> Cc: oulijun <oulijun@...wei.com>, dledford@...hat.com, sean.hefty@...el.com, hal.rosenstock@...il.com, davem@...emloft.net, jeffrey.t.kirsher@...el.com, jiri@...lanox.com, ogerlitz@...lanox.com, linuxarm@...wei.com, linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org, netdev@...r.kernel.org, gongyangming@...wei.com, xiaokun@...wei.com, tangchaofei@...wei.com, haifeng.wei@...wei.com, yisen.zhuang@...wei.com, yankejian@...wei.com, lisheng011@...wei.com, charles.chenxin@...wei.com Subject: Re: [PATCH v5 09/21] IB/hns: Add hca support Tue, Apr 26, 2016 at 04:18:21PM CEST, leon@...nel.org wrote: >On Tue, Apr 26, 2016 at 02:34:44PM +0800, oulijun wrote: >> On 2016/4/24 15:54, Leon Romanovsky wrote: <snip> >> >> +int hns_roce_bitmap_alloc(struct hns_roce_bitmap *bitmap, u32 *obj) >> >> +{ >> >> + int ret = 0; >> >> + >> >> + spin_lock(&bitmap->lock); >> >> + *obj = find_next_zero_bit(bitmap->table, bitmap->max, bitmap->last); >> >> + if (*obj >= bitmap->max) { >> >> + bitmap->top = (bitmap->top + bitmap->max + bitmap->reserved_top) >> >> + & bitmap->mask; >> >> + *obj = find_first_zero_bit(bitmap->table, bitmap->max); >> > >> > find_first_zero_bit function returns "unsigned long" which may or may >> > not be equal to u32 on some architectures. >> > >> Hi Leon, >> I appreciate your keen eye. this code is meant for ARM64bit therefore should run corretly for 64-bit AARCH64. The driver should run correctly on any arch. >> I will consider changing it as part of good partice and better portability " >> I will give a primary plan to modified it. >> for example: >> *obj = (u32)find_next_zero_bit(bitmap->table, bitmap->max, bitmap->last); >> Beause the max size of bitmap->table is u32 in current version. >> >> int hns_roce_bitmap_init(struct hns_roce_bitmap *bitmap, u32 num, u32 mask, >> u32 reserved_bot, u32 reserved_top) >> { >> u32 i; >> >> if (num != roundup_pow_of_two(num)) >> return -EINVAL; >> >> bitmap->last = 0; >> bitmap->top = 0; >> bitmap->max = num - reserved_top; >> bitmap->mask = mask; >> bitmap->reserved_top = reserved_top; >> spin_lock_init(&bitmap->lock); >> bitmap->table = kcalloc(BITS_TO_LONGS(bitmap->max), sizeof(long), >> GFP_KERNEL); >> >> Is this plan ok? > >No, >You are submitting new driver, please do it properly (without casting) >from the beginning. > >> >> Thanks >> Lijun Ou >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in >> the body of a message to majordomo@...r.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists