netdev - Re: [PATCH v2] net: Add Qualcomm IPC router

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 27 Apr 2016 12:22:42 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	bjorn.andersson@...aro.org
Cc:	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	linux-arm-msm@...r.kernel.org, courtney.cavin@...ymobile.com,
	bjorn.andersson@...ymobile.com
Subject: Re: [PATCH v2] net: Add Qualcomm IPC router

From: Bjorn Andersson <bjorn.andersson@...aro.org>
Date: Tue, 26 Apr 2016 22:48:05 -0700

> +	rc = qcom_smd_send(qdev->channel, skb->data, skb->len);

I truly dislike adding networking protocols that depend upon some
piece of infrastructure that only some platforms can enable, it's even
worse when that set of platforms doesn't intersect with x86-64.

When you do things like this, it's quite hard to make protocol wide
changes to APIs because build testing becomes an issue.

This code can now only be build tested on ARCH_QCOM architectures, and
that's a serious negative downside.