netdev - Re: [PATCH 1/5] phylib: don't return NULL from get_phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <57211CDD.5000903@gmail.com>
Date:	Wed, 27 Apr 2016 13:11:09 -0700
From:	Florian Fainelli <f.fainelli@...il.com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
	Vivien Didelot <vivien.didelot@...oirfairelinux.com>,
	"David S. Miller" <davem@...emloft.net>
Cc:	arnd@...db.de, Andrew Lunn <andrew@...n.ch>,
	netdev@...r.kernel.org, kernel@...oirfairelinux.com
Subject: Re: [PATCH 1/5] phylib: don't return NULL from get_phy_device()

On 27/04/16 13:12, Sergei Shtylyov wrote:
> Hello.
> 
> On 04/27/2016 10:30 PM, Vivien Didelot wrote:
> 
>>> Arnd Bergmann asked that get_phy_device() returns either NULL or the
>>> error
>>> value,  not both on error.  Do as he said, return ERR_PTR(-ENODEV)
>>> instead
>>> of NULL when the PHY ID registers read as  all ones.
>>>
>>> Suggested-by: Arnd Bergmann <arnd@...db.de>
>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
>>>
>>> ---
>>>   drivers/net/phy/phy_device.c |    2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> Index: net-next/drivers/net/phy/phy_device.c
>>> ===================================================================
>>> --- net-next.orig/drivers/net/phy/phy_device.c
>>> +++ net-next/drivers/net/phy/phy_device.c
>>> @@ -529,7 +529,7 @@ struct phy_device *get_phy_device(struct
>>>
>>>       /* If the phy_id is mostly Fs, there is no device there */
>>>       if ((phy_id & 0x1fffffff) == 0x1fffffff)
>>> -        return NULL;
>>> +        return ERR_PTR(-ENODEV);
>>>
>>>       return phy_device_create(bus, addr, phy_id, is_c45, &c45_ids);
>>>   }
>>
>> This particular commit, merged as:
>>
>>      b74766a0a0fe ("phylib: don't return NULL from get_phy_device()")
>>
>> breaks my 3-switch DSA setup with the following error:
>>
>>      fec: probe of 400d1000.ethernet failed with error -22
>>
>> Reverting c971c0e580a6 ("Merge branch 'get_phy_device-retval'") restores
>> a working setup.
> 
>    I think I was able to follow this to the get_phy_device() call in
> fixed_phy_register() but I'm unable to see why it fails now and didn't
> before. Are you using fixed_phy.c at all?

I am using fixed_phy.c and yes, this fails for me too, sorry for not
catching that when you posted the patches :/

-- 
Florian