netdev - Re: [PATCH net-next 1/1] pch_gbe: replace private tx ring lock with common netif_tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160427212848.GA10269@electric-eye.fr.zoreil.com>
Date:	Wed, 27 Apr 2016 23:28:48 +0200
From:	Francois Romieu <romieu@...zoreil.com>
To:	Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
Cc:	netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: [PATCH net-next 1/1] pch_gbe: replace private tx ring lock with
 common netif_tx_lock

Nikolay Aleksandrov <nikolay@...ulusnetworks.com> :
> On 04/27/2016 12:49 AM, Francois Romieu wrote:
[...]
> > @@ -1652,7 +1652,7 @@ pch_gbe_clean_tx(struct pch_gbe_adapter *adapter,
> >  
> >  		netdev_dbg(adapter->netdev, "next_to_clean : %d\n",
> >  			   tx_ring->next_to_clean);
> > -		spin_unlock(&tx_ring->tx_lock);
> > +		netif_tx_lock(adapter->netdev);
> 
> Shouldn't this be netif_tx_unlock ?

It should. Thanks for reviewing.

-- 
Ueimor