netdev - Re: [PATCH v2 0/2] pegasus: correct buffer sizes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 27 Apr 2016 09:46:15 +0200
From:	Johannes Berg <johannes@...solutions.net>
To:	Petko Manolov <petkan@...-labs.com>, netdev@...r.kernel.org
Cc:	davem@...emloft.net, a1291762@...il.com
Subject: Re: [PATCH v2 0/2] pegasus: correct buffer sizes

On Wed, 2016-04-27 at 10:35 +0300, Petko Manolov wrote:
> 
> Nearly all Pegasus devices may append the RX status to the end of the
> received  packet.  It is the default setup for the driver.  The
> actual ethernet packet is  4 bytes shorter.  Why and when 'pkt_len -=
> 4' became 'pkt_len -= 8' is again hidden in the mists of time.  There
> might have been a good reason to do so, but multiple reads of the
> datasheet did not point me to any.
> 

Wild guess: (some) devices pass the FCS, perhaps depending on the
configuration?

johannes