netdev - Re: [PATCH v2 0/2] pegasus: correct buffer sizes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1461750245.3723.8.camel@sipsolutions.net>
Date:	Wed, 27 Apr 2016 11:44:05 +0200
From:	Johannes Berg <johannes@...solutions.net>
To:	Petko Manolov <petkan@...-labs.com>
Cc:	netdev@...r.kernel.org, davem@...emloft.net, a1291762@...il.com
Subject: Re: [PATCH v2 0/2] pegasus: correct buffer sizes

On Wed, 2016-04-27 at 12:33 +0300, Petko Manolov wrote:
> 
> Your guess turned out to be not so wild.  ;)  All Pegasus devices are
> configured  (by the driver) to append CRC at the end of each RX
> packet.  However, the driver reports packet length that does not
> include it.  

Interesting, then my guess was wrong though, since the length is
reported without it, or am I misunderstanding this?

> I doubt the appended CRC is being silently verified by the upper
> layer, bit i might be wrong of course.

It's even "outside" the skb as you describe it, so it can't even be
touched, no?

> Perhaps it is best if instruct the device to not include the CRC as
> it seems ignored anyway.

Yeah, there's no point in passing it over the bus.

johannes