netdev - Re: [PATCH net] ip_tunnel: fix preempt warning in ip tunnel creation/updating

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1461845394.5535.96.camel@edumazet-glaptop3.roam.corp.google.com>
Date:	Thu, 28 Apr 2016 05:09:54 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Paolo Abeni <pabeni@...hat.com>
Cc:	netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
	Alexey Kuznetsov <kuznet@....inr.ac.ru>, tgraf@...g.ch,
	pshelar@...ira.com, jbenc@...hat.com, hannes@...essinduktion.org,
	sergei.shtylyov@...entembedded.com,
	Tom Herbert <tom@...bertland.com>
Subject: Re: [PATCH net] ip_tunnel: fix preempt warning in ip tunnel
 creation/updating

On Thu, 2016-04-28 at 11:04 +0200, Paolo Abeni wrote:
> After the commit e09acddf873b ("ip_tunnel: replace dst_cache with generic
> implementation"), a preemption debug warning is triggered on ip4
> tunnels updating; the dst cache helper needs to be invoked in unpreemptible
> context.
> 
> We don't need to load the cache on tunnel update, so this commit fixes
> the warning replacing the load with a dst cache reset, which is
> preempt safe.
> 
> Fixes: e09acddf873b ("ip_tunnel: replace dst_cache with generic
> implementation")
> 
> Reported-by: Eric Dumazet <eric.dumazet@...il.com>
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>
> ---

Seems good to me, thanks.

Note that the Fixes: tag should not be followed by a blank line.
(And presumably no line wrap is necessary)
It really is part of the standard set of tags.
They should be grouped together.

Acked-by: Eric Dumazet <edumazet@...gle.com>