netdev - Re: [PATCH net-next] vxlan: fix initialization with custom link parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <572226ED.6000903@6wind.com>
Date:	Thu, 28 Apr 2016 17:06:21 +0200
From:	Nicolas Dichtel <nicolas.dichtel@...nd.com>
To:	Jiri Benc <jbenc@...hat.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] vxlan: fix initialization with custom link
 parameters

Le 28/04/2016 16:36, Jiri Benc a écrit :
> Commit 0c867c9bf84c ("vxlan: move Ethernet initialization to a separate
> function") changed initialization order and as an unintended result, when the
> user specifies additional link parameters (such as IFLA_ADDRESS) while
> creating vxlan interface, those are overwritten by vxlan_ether_setup later.
> 
> It's necessary to call ether_setup from withing the ->setup callback. That
> way, the correct parameters are set by rtnl_create_link later. This is done
> also for VXLAN-GPE, as we don't know the interface type yet at that point,
> and changed to the correct interface type later.
> 
> Fixes: 0c867c9bf84c ("vxlan: move Ethernet initialization to a separate function")
> Reported-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>
> Signed-off-by: Jiri Benc <jbenc@...hat.com>
Tested-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>