netdev - Re: [PATCH net-next] net: snmp: fix 64bit stats on 32bit arches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160428.115553.503130126299327138.davem@davemloft.net>
Date:	Thu, 28 Apr 2016 11:55:53 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	nicolas.dichtel@...nd.com, edumazet@...gle.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: snmp: fix 64bit stats on 32bit arches

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Thu, 28 Apr 2016 06:33:24 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> I accidentally replaced BH disabling by preemption disabling
> in SNMP_ADD_STATS64() and SNMP_UPD_PO_STATS64() on 32bit builds.
> 
> For 64bit stats on 32bit arch, we really need to disable BH,
> since the "struct u64_stats_sync syncp" might be manipulated
> both from process and BH contexts.
> 
> Fixes: 6aef70a851ac ("net: snmp: kill various STATS_USER() helpers")
> Reported-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>
> Tested-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied.