netdev - Re: [RFC PATCH net] ipv6/ila: fix nlsize calculation for lwtunnel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160428.121639.1149681033434022894.davem@davemloft.net>
Date:	Thu, 28 Apr 2016 12:16:39 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	tom@...bertland.com
Cc:	nicolas.dichtel@...nd.com, netdev@...r.kernel.org
Subject: Re: [RFC PATCH net] ipv6/ila: fix nlsize calculation for lwtunnel

From: Tom Herbert <tom@...bertland.com>
Date: Thu, 28 Apr 2016 09:07:25 -0700

> On Wed, Apr 27, 2016 at 12:20 PM, David Miller <davem@...emloft.net> wrote:
>> From: Nicolas Dichtel <nicolas.dichtel@...nd.com>
>> Date: Fri, 22 Apr 2016 17:58:02 +0200
>>
>>> The handler 'ila_fill_encap_info' adds one attribute: ILA_ATTR_LOCATOR.
>>>
>>> Fixes: 65d7ab8de582 ("net: Identifier Locator Addressing module")
>>> CC: Tom Herbert <tom@...bertland.com>
>>> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>
>>> ---
>>>
>>> Tom, when I read the comment, I feel I'm misssing something, but what?
>>
>> Tom, seriously, please look at this.
>>
> Yes, it is an issue. Need to do add size for ILA_ATTR_LOCATOR and
> ILA_ATTR_CSUM_MODE. Also not we made ILA_ATTR_CSUM_MODE u64 in fill
> encap info. I will send a path shortly.
> 
>> And with recent changes in net-next the csum attribute size needs to
>> be specified as well, plus the locator needs to use the 64-bit
>> alignment sizing helper.
> 
> Something other than nla_put_u64_64bit?

That's what it should use, yes.