netdev - Re: [PATCH net-next V2] tuntap: calculate rps hash only when needed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160428.163908.1659396336398436917.davem@davemloft.net>
Date:	Thu, 28 Apr 2016 16:39:08 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	jasowang@...hat.com
Cc:	davem@...emloft.ne, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, mst@...hat.com
Subject: Re: [PATCH net-next V2] tuntap: calculate rps hash only when needed

From: Jason Wang <jasowang@...hat.com>
Date: Mon, 25 Apr 2016 23:13:42 -0400

> There's no need to calculate rps hash if it was not enabled. So this
> patch export rps_needed and check it before trying to get rps
> hash. Tests (using pktgen to inject packets to guest) shows this can
> improve pps about 13% (when rps is disabled).
> 
> Before:
> ~1150000 pps
> After:
> ~1300000 pps
> 
> Cc: Michael S. Tsirkin <mst@...hat.com>
> Signed-off-by: Jason Wang <jasowang@...hat.com>

Applied, thanks Jason.