netdev - Re: [PATCH] net: phy: at803x: only the AT8030 needs a hardware reset on link change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160428.164845.489992418800962568.davem@davemloft.net>
Date:	Thu, 28 Apr 2016 16:48:45 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	timur@...eaurora.org
Cc:	netdev@...r.kernel.org, f.fainelli@...il.com,
	marek.belisko@...il.com, ujhelyi.m@...il.com, zonque@...il.com
Subject: Re: [PATCH] net: phy: at803x: only the AT8030 needs a hardware
 reset on link change

From: Timur Tabi <timur@...eaurora.org>
Date: Tue, 26 Apr 2016 12:44:18 -0500

> Commit 13a56b44 ("at803x: Add support for hardware reset") added a
> work-around for a hardware bug on the AT8030.  However, the work-around
> was being called for all 803x PHYs, even those that don't need it.
> Function at803x_link_change_notify() checks to make sure that it only
> resets the PHY on the 8030, but it makes more sense to not call that
> function at all if it isn't needed.
> 
> Signed-off-by: Timur Tabi <timur@...eaurora.org>

Applied, thanks.