netdev - Re: [PATCH next v2] ipvlan: Fix failure path in dev registration during link creation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160428.172324.972705903601258798.davem@davemloft.net>
Date:	Thu, 28 Apr 2016 17:23:24 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	mahesh@...dewar.net
Cc:	maheshb@...gle.com, edumazet@...gle.com, netdev@...r.kernel.org,
	ebiederm@...ssion.com
Subject: Re: [PATCH next v2] ipvlan: Fix failure path in dev registration
 during link creation

From: Mahesh Bandewar <mahesh@...dewar.net>
Date: Wed, 27 Apr 2016 14:59:27 -0700

> From: Mahesh Bandewar <maheshb@...gle.com>
> 
> When newlink creation fails at device-registration, the port->count
> is decremented twice. Francesco Ruggeri (fruggeri@...sta.com) found
> this issue in Macvlan and the same exists in IPvlan driver too.
> 
> While fixing this issue I noticed another issue of missing unregister
> in case of failure, so adding it to the fix which is similar to the
> macvlan fix by Francesco in commit 308379607548 ("macvlan: fix failure
> during registration v3")
> 
> Reported-by: Francesco Ruggeri <fruggeri@...sta.com>
> Signed-off-by: Mahesh Bandewar <maheshb@...gle.com>

Applied, thanks.