netdev - Re: [PATCH v2 net-next 1/2] tcp: remove an unnecessary check in tcp_tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1461818105.5535.88.camel@edumazet-glaptop3.roam.corp.google.com>
Date:	Wed, 27 Apr 2016 21:35:05 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Soheil Hassas Yeganeh <soheil.kdev@...il.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org, kafai@...com,
	willemb@...gle.com, edumazet@...gle.com, ycheng@...gle.com,
	ncardwell@...gle.com, Soheil Hassas Yeganeh <soheil@...gle.com>
Subject: Re: [PATCH v2 net-next 1/2] tcp: remove an unnecessary check in
 tcp_tx_timestamp

On Wed, 2016-04-27 at 23:39 -0400, Soheil Hassas Yeganeh wrote:
> From: Soheil Hassas Yeganeh <soheil@...gle.com>
> 
> Remove the redundant check for sk->sk_tsflags in tcp_tx_timestamp.
> 
> tcp_tx_timestamp() receives the tsflags as a parameter. As a
> result the "sk->sk_tsflags || tsflags" is redundant, since
> tsflags already includes sk->sk_tsflags plus overrides from
> control messages.
> 
> Signed-off-by: Soheil Hassas Yeganeh <soheil@...gle.com>
> ---

Acked-by: Eric Dumazet <edumazet@...gle.com>