lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 28 Apr 2016 08:49:37 +0200 From: Johannes Berg <johannes@...solutions.net> To: David Laight <David.Laight@...LAB.COM>, Petko Manolov <petkan@...-labs.com> Cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "davem@...emloft.net" <davem@...emloft.net>, "a1291762@...il.com" <a1291762@...il.com> Subject: Re: [PATCH v2 0/2] pegasus: correct buffer sizes On Wed, 2016-04-27 at 16:26 +0000, David Laight wrote: > From: Johannes Berg > > > > Sent: 27 April 2016 10:44 > > On Wed, 2016-04-27 at 12:33 +0300, Petko Manolov wrote: > > > > > > > > > Your guess turned out to be not so wild.;)All Pegasus devices are > > > configured (by the driver) to append CRC at the end of each RX > > > packet.However, the driver reports packet length that does not > > > include it. > > Interesting, then my guess was wrong though, since the length is > > reported without it, or am I misunderstanding this? > ... > > It is even possible that the crc is written into the rx buffer even > though the length the hardware reports excludes it. > Right. I think a proper test would be to construct some kind of ethernet-only frames, and check that they come out properly on the other side. IP always has its own length field, so may be happy with trailing garbage reported to the network stack, but doing raw ethernet will let you check that the frame length is correct. johannes
Powered by blists - more mailing lists