netdev - Re: [PATCH] net: l2tp: fix reversed udp6 checksum flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160501.193341.818074706429009741.davem@davemloft.net>
Date:	Sun, 01 May 2016 19:33:41 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	shankerwangmiao@...il.com
Cc:	netdev@...r.kernel.org, jchapman@...alix.com, therbert@...gle.com
Subject: Re: [PATCH] net: l2tp: fix reversed udp6 checksum flags

From: Wang Shanker <shankerwangmiao@...il.com>
Date: Fri, 29 Apr 2016 01:29:43 +0800

> This patch fixes a bug which causes the behavior of whether to ignore
> udp6 checksum of udp6 encapsulated l2tp tunnel contrary to what
> userspace program requests.
> 
> When the flag `L2TP_ATTR_UDP_ZERO_CSUM6_RX` is set by userspace, it is
> expected that udp6 checksums of received packets of the l2tp tunnel
> to create should be ignored. In `l2tp_netlink.c`:
> `l2tp_nl_cmd_tunnel_create()`, `cfg.udp6_zero_rx_checksums` is set
> according to the flag, and then passed to `l2tp_core.c`:
> `l2tp_tunnel_create()` and then `l2tp_tunnel_sock_create()`. In
> `l2tp_tunnel_sock_create()`, `udp_conf.use_udp6_rx_checksums` is set
> the same to `cfg.udp6_zero_rx_checksums`. However, if we want the
> checksum to be ignored, `udp_conf.use_udp6_rx_checksums` should be set
> to `false`, i.e. be set to the contrary. Similarly, the same should be
> done to `udp_conf.use_udp6_tx_checksums`.
> 
> Signed-off-by: Miao Wang <shankerwangmiao@...il.com>

Applied, thanks.