netdev - Re: [PATCH iproute2] tc: add bash-completion function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160502151414.0c9c3e3a@xeon-e3>
Date:	Mon, 2 May 2016 15:14:14 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Quentin Monnet <quentin.monnet@...nd.com>
Cc:	alexei.starovoitov@...il.com, hadi@...atatu.com,
	netdev@...r.kernel.org, vincent.jardin@...nd.com
Subject: Re: [PATCH iproute2] tc: add bash-completion function

On Fri, 29 Apr 2016 10:27:11 +0200
Quentin Monnet <quentin.monnet@...nd.com> wrote:

> Add function for command completion for tc in bash, and update Makefile
> to install it:
> 
> - Under /usr/share/bash-completion/completions/ (default).
> - Or under /etc/bash_completions.d/, which is the old directory for
>   bash-completion, if /usr/share/bash-completion/completions/ is not
>   found AND /etc/bash_completions.d/ exists already.
> 
> Inside iproute2 repository, the completion code is in a new
> `bash-completion` toplevel directory.
> 
> Signed-off-by: Quentin Monnet <quentin.monnet@...nd.com>

Rather than having an if statement in the install; lets follow how
other paths are handles.
 * default value should be what current distros use /usr/share
 * other distro's can override it with environment variable.

Something like:

Makefile:
PREFIX?=/usr
LIBDIR?=$(PREFIX)/lib
SBINDIR?=/sbin
CONFDIR?=/etc/iproute2
DATADIR?=$(PREFIX)/share
DOCDIR?=$(DATADIR)/doc/iproute2
MANDIR?=$(DATADIR)/man
ARPDDIR?=/var/lib/arpd
KERNEL_INCLUDE?=/usr/include
BASH_COMPDIR?=$(DATADIR)/bash-completion/completions/