lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20160501.214934.2250379996423526821.davem@davemloft.net> Date: Sun, 01 May 2016 21:49:34 -0400 (EDT) From: David Miller <davem@...emloft.net> To: tbingham@...mai.com Cc: netdev@...r.kernel.org, Jason@...c4.com Subject: Re: [PATCH] net: Implement net_dbg_ratelimited() for CONFIG_DYNAMIC_DEBUG case From: Tim Bingham <tbingham@...mai.com> Date: Fri, 29 Apr 2016 13:30:23 -0400 > Prior to commit d92cff89a0c8 ("net_dbg_ratelimited: turn into no-op > when !DEBUG") the implementation of net_dbg_ratelimited() was buggy > for both the DEBUG and CONFIG_DYNAMIC_DEBUG cases. > > The bug was that net_ratelimit() was being called and, despite > returning true, nothing was being printed to the console. This > resulted in messages like the following - > > "net_ratelimit: %d callbacks suppressed" > > with no other output nearby. > > After commit d92cff89a0c8 ("net_dbg_ratelimited: turn into no-op when > !DEBUG") the bug is fixed for the DEBUG case. However, there's no > output at all for CONFIG_DYNAMIC_DEBUG case. > > This patch restores debug output (if enabled) for the > CONFIG_DYNAMIC_DEBUG case. > > Add a definition of net_dbg_ratelimited() for the CONFIG_DYNAMIC_DEBUG > case. The implementation takes care to check that dynamic debugging is > enabled before calling net_ratelimit(). > > Fixes: d92cff89a0c8 ("net_dbg_ratelimited: turn into no-op when !DEBUG") > Signed-off-by: Tim Bingham <tbingham@...mai.com> Looks good, applied and queued up for -stable, thanks.
Powered by blists - more mailing lists