netdev - Re: [PATCH net] gre: do not pull header in ICMP error processing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160502.002057.896629867341178886.davem@davemloft.net>
Date:	Mon, 02 May 2016 00:20:57 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	jbenc@...hat.com
Cc:	netdev@...r.kernel.org, pshelar@...ira.com
Subject: Re: [PATCH net] gre: do not pull header in ICMP error processing

From: Jiri Benc <jbenc@...hat.com>
Date: Fri, 29 Apr 2016 23:31:32 +0200

> iptunnel_pull_header expects that IP header was already pulled; with this
> expectation, it pulls the tunnel header. This is not true in gre_err.
> Furthermore, ipv4_update_pmtu and ipv4_redirect expect that skb->data points
> to the IP header.
> 
> We cannot pull the tunnel header in this path. It's just a matter of not
> calling iptunnel_pull_header - we don't need any of its effects.
> 
> Fixes: bda7bb463436 ("gre: Allow multiple protocol listener for gre protocol.")
> Signed-off-by: Jiri Benc <jbenc@...hat.com>

Applied and queued up for -stable, thanks Jiri.