netdev - Re: [PATCH net] cxgb3: fix out of bounds read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 2 May 2016 06:30:42 -0400 (EDT)
From:	Jan Stancek <jstancek@...hat.com>
To:	David Miller <davem@...emloft.net>, mschmidt@...hat.com
Cc:	netdev@...r.kernel.org, santosh@...lsio.com
Subject: Re: [PATCH net] cxgb3: fix out of bounds read



----- Original Message -----
> From: "David Miller" <davem@...emloft.net>
> To: mschmidt@...hat.com
> Cc: netdev@...r.kernel.org, santosh@...lsio.com, jstancek@...hat.com
> Sent: Monday, 2 May, 2016 3:00:00 AM
> Subject: Re: [PATCH net] cxgb3: fix out of bounds read
> 
> From: Michal Schmidt <mschmidt@...hat.com>
> Date: Fri, 29 Apr 2016 11:06:50 +0200
> 
> > An out of bounds read of 2 bytes was discovered in cxgb3 with KASAN.
> > 
> > t3_config_rss() expects both arrays it gets as parameters to have
> > terminators. setup_rss(), the caller, forgets to add a terminator to
> > one of the arrays. Thankfully the iteration in t3_config_rss() stops
> > anyway, but in the last iteration the check for the terminator
> > is an out of bounds read.
> > 
> > Add the missing terminator to rspq_map[].
> > 
> > Reported-by: Jan Stancek <jstancek@...hat.com>
> > Signed-off-by: Michal Schmidt <mschmidt@...hat.com>
> 
> Applied.
> 

KASAN BUG message went away for me with this patch.

Regards,
Jan