netdev - Re: [PATCHv2 bluetooth-next 03/10] 6lowpan: remove ipv6 module request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5728EB15.7060801@osg.samsung.com>
Date:	Tue, 3 May 2016 20:16:53 +0200
From:	Stefan Schmidt <stefan@....samsung.com>
To:	Alexander Aring <aar@...gutronix.de>, linux-wpan@...r.kernel.org
Cc:	kernel@...gutronix.de, marcel@...tmann.org,
	jukka.rissanen@...ux.intel.com, hannes@...essinduktion.org,
	mcr@...delman.ca, werner@...esberger.net,
	linux-bluetooth@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCHv2 bluetooth-next 03/10] 6lowpan: remove ipv6 module
 request

Hello.

On 20/04/16 10:19, Alexander Aring wrote:
> Since we use exported function from ipv6 kernel module we don't need to
> request the module anymore to have ipv6 functionality.
>
> Signed-off-by: Alexander Aring<aar@...gutronix.de>
> ---
>   net/6lowpan/core.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/net/6lowpan/core.c b/net/6lowpan/core.c
> index fbae31e..824d1bc 100644
> --- a/net/6lowpan/core.c
> +++ b/net/6lowpan/core.c
> @@ -158,8 +158,6 @@ static int __init lowpan_module_init(void)
>   		return ret;
>   	}
>   
> -	request_module_nowait("ipv6");
> -
>   	request_module_nowait("nhc_dest");
>   	request_module_nowait("nhc_fragment");
>   	request_module_nowait("nhc_hop");
Good point.

Reviewed-by: Stefan Schmidt<stefan@....samsung.com>

regards
Stefan Schmidt