netdev - Re: [PATCH v2] net: mvneta: Remove superfluous SMP function call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160503.152806.1985815306043431466.davem@davemloft.net>
Date:	Tue, 03 May 2016 15:28:06 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	anna-maria@...utronix.de
Cc:	linux-kernel@...r.kernel.org, rt@...utronix.de,
	thomas.petazzoni@...e-electrons.com, netdev@...r.kernel.org
Subject: Re: [PATCH v2] net: mvneta: Remove superfluous SMP function call

From: Anna-Maria Gleixner <anna-maria@...utronix.de>
Date: Mon,  2 May 2016 11:02:51 +0200

> Since commit 3b9d6da67e11 ("cpu/hotplug: Fix rollback during error-out
> in __cpu_disable()") it is ensured that callbacks of CPU_ONLINE and
> CPU_DOWN_PREPARE are processed on the hotplugged CPU. Due to this SMP
> function calls are no longer required.
> 
> Replace smp_call_function_single() with a direct call to
> mvneta_percpu_enable() or mvneta_percpu_disable(). The functions do
> not require to be called with interrupts disabled, therefore the
> smp_call_function_single() calling convention is not preserved.
> 
> Cc: Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>
> Cc: netdev@...r.kernel.org
> Signed-off-by: Anna-Maria Gleixner <anna-maria@...utronix.de>

Applied, thanks.