netdev - Re: [PATCH net v2] vlan: Propagate MAC address to VLANs unless explicitly set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160504.115815.1348535190105538815.davem@davemloft.net>
Date:	Wed, 04 May 2016 11:58:15 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	mkubecek@...e.cz
Cc:	mmanning@...cade.com, netdev@...r.kernel.org
Subject: Re: [PATCH net v2] vlan: Propagate MAC address to VLANs unless
 explicitly set

From: Michal Kubecek <mkubecek@...e.cz>
Date: Wed, 4 May 2016 11:28:02 +0200

> The commit message says "unless explicitly changed for the VLAN" but
> what you really check is "if it is the same as real device MAC address".
> This, in general, is not the same. (I believe this is what David tries
> to explain from the start.)

Even more proof that these MAC checks are rediculous, confusing, and
that we need to use a boolean state stores in the vlan private in
order to implement the intended semantics properly and more importantly
"clearly".