netdev - Re: [PATCH net-next] gre: change gre_parse_header to return the header length

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160504.124526.864764985279452152.davem@davemloft.net>
Date:	Wed, 04 May 2016 12:45:26 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	jbenc@...hat.com
Cc:	netdev@...r.kernel.org, tom@...bertland.com
Subject: Re: [PATCH net-next] gre: change gre_parse_header to return the
 header length

From: Jiri Benc <jbenc@...hat.com>
Date: Tue,  3 May 2016 15:00:21 +0200

> It's easier for gre_parse_header to return the header length instead of
> filing it into a parameter. That way, the callers that don't care about the
> header length can just check whether the returned value is lower than zero.
> 
> In gre_err, the tunnel header must not be pulled. See commit b7f8fe251e46
> ("gre: do not pull header in ICMP error processing") for details.
> 
> This patch reduces the conflict between the mentioned commit and commit
> 95f5c64c3c13 ("gre: Move utility functions to common headers").
> 
> Signed-off-by: Jiri Benc <jbenc@...hat.com>

Applied.