netdev - Re: [PATCH] net: fec: only clear a queue's work bit if the queue was emptied

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160504.140910.2171362814117515274.davem@davemloft.net>
Date:	Wed, 04 May 2016 14:09:10 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	u.kleine-koenig@...gutronix.de
Cc:	fugang.duan@....com, kernel@...gutronix.de, netdev@...r.kernel.org
Subject: Re: [PATCH] net: fec: only clear a queue's work bit if the queue
 was emptied

From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Date: Tue,  3 May 2016 16:38:53 +0200

> In the receive path a queue's work bit was cleared unconditionally even
> if fec_enet_rx_queue only read out a part of the available packets from
> the hardware. This resulted in not reading any packets in the next napi
> turn and so packets were delayed or lost.
> 
> The obvious fix is to only clear a queue's bit when the queue was
> emptied.
> 
> Fixes: 4d494cdc92b3 ("net: fec: change data structure to support multiqueue")
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

Applied and queued up for -stable, thanks.