netdev - Re: [PATCH net-next 0/3] gre: receive also TEB packets for lwtunnels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160504075250.GA25241@penelope.isobedori.kobe.vergenet.net>
Date:	Wed, 4 May 2016 16:52:53 +0900
From:	Simon Horman <simon.horman@...ronome.com>
To:	Jiri Benc <jbenc@...hat.com>
Cc:	netdev@...r.kernel.org, Thomas Graf <tgraf@...g.ch>,
	pravin shelar <pshelar@....org>
Subject: Re: [PATCH net-next 0/3] gre: receive also TEB packets for lwtunnels

On Tue, May 03, 2016 at 05:10:05PM +0200, Jiri Benc wrote:
> NOTE: this patchset needs net merged to net-next.
> 
> This allows lwtunnel users to get also packets with ETH_P_TEB protocol
> specified in GRE header through an ipgre interface. There's really nothing
> special about these packets in the case of lwtunnels - it's just an inner
> protocol like any other. The only complications stem from keeping
> compatibility with other uses of GRE.
> 
> This will be used by openvswitch to support eth_push and eth_pop actions.
> I'd also like to see tc support for lwtunnels (this feature included) in the
> future.
> 
> The first patch is not directly related and can be submitted standalone if
> needed.

I have exercised this patch-set using Open vSwitch both with
and without the patchset I posted earlier this afternoon to
make use of this new feature:

"[PATCH v9 net-next 0/7] openvswitch: support for layer 3 encapsulated packets"

All three patches:

Tested-by: Simon Horman <simon.horman@...ronome.com>

> Jiri Benc (3):
>   gre: remove superfluous pskb_may_pull
>   gre: move iptunnel_pull_header down to ipgre_rcv
>   gre: receive also TEB packets for lwtunnels
> 
>  include/net/ip_tunnels.h |  1 +
>  net/ipv4/gre_demux.c     |  5 +----
>  net/ipv4/ip_gre.c        | 48 +++++++++++++++++++++++++++++++++++-------------
>  3 files changed, 37 insertions(+), 17 deletions(-)
> 
> -- 
> 1.8.3.1
>