netdev - Re: [patch net-next] vrf: add exit function and allow module unload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1462357422.1666076.597731009.4C5E1305@webmail.messagingengine.com>
Date:	Wed, 04 May 2016 12:23:42 +0200
From:	Hannes Frederic Sowa <hannes@...essinduktion.org>
To:	Jiri Pirko <jiri@...nulli.us>, netdev@...r.kernel.org
Cc:	davem@...emloft.net, idosch@...lanox.com, eladr@...lanox.com,
	yotamg@...lanox.com, dsa@...ulusnetworks.com,
	shm@...ulusnetworks.com
Subject: Re: [patch net-next] vrf: add exit function and allow module unload

Hello Jiri,

On Wed, May 4, 2016, at 12:20, Jiri Pirko wrote:
>  drivers/net/vrf.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/net/vrf.c b/drivers/net/vrf.c
> index 8a8f1e5..b217c2d 100644
> --- a/drivers/net/vrf.c
> +++ b/drivers/net/vrf.c
> @@ -839,7 +839,14 @@ error:
>  	return rc;
>  }
>  
> +static void __exit vrf_exit_module(void)
> +{
> +       rtnl_link_unregister(&vrf_link_ops);
> +       unregister_netdevice_notifier(&vrf_notifier_block);
> +}
> +
>  module_init(vrf_init_module);
> +module_exit(vrf_exit_module);

The dst_entries created by vrf don't carry a reference to THIS_MODULE
but have a code dependency to the vrf module (e.g. via
vrf_output/vrf_output6) that gets published. This is exactly the same
why ipv6 cannot be unloaded.

Bye,
Hannes