lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20160505230659.GI7972@lunn.ch> Date: Fri, 6 May 2016 01:06:59 +0200 From: Andrew Lunn <andrew@...n.ch> To: Vivien Didelot <vivien.didelot@...oirfairelinux.com> Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, kernel@...oirfairelinux.com, "David S. Miller" <davem@...emloft.net>, Florian Fainelli <f.fainelli@...il.com> Subject: Re: [RFC PATCH net-next 01/20] net: dsa: mv88e6xxx: factorize PHY access with PPU > { > struct mv88e6xxx_priv_state *ps = ds_to_priv(ds); > int addr = mv88e6xxx_port_to_phy_addr(ps, port); > - int ret; > + int err; > > if (addr < 0) > return 0xffff; > > + We don't want an extra blank line. I'm surprised checkpatch did not warn about this. > mutex_lock(&ps->smi_mutex); > - ret = _mv88e6xxx_phy_write(ps, addr, regnum, val); > + > + if (mv88e6xxx_has(ps, MV88E6XXX_FLAG_PPU)) > + err = _mv88e6xxx_phy_write_ppu(ps, addr, regnum, val); > + else > + err = _mv88e6xxx_phy_write(ps, addr, regnum, val); > + > mutex_unlock(&ps->smi_mutex); > - return ret; > + > + return err; Please don't rename ret to err. This patch is about phy reading and writing, and i don't expect to see anything else here. It makes it harder to review. Andrew
Powered by blists - more mailing lists