netdev - Re: [net-next 08/15] i40e: Allow user to change input set mask for flow director

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 04 May 2016 23:57:29 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	kiran.patil@...el.com
Cc:	jeffrey.t.kirsher@...el.com, netdev@...r.kernel.org,
	nhorman@...hat.com, sassmann@...hat.com, jogreene@...hat.com
Subject: Re: [net-next 08/15] i40e: Allow user to change input set mask for
 flow director

From: "Patil, Kiran" <kiran.patil@...el.com>
Date: Wed, 4 May 2016 19:47:26 -0700

> This is not new feature implemented in i40e driver. This is the
> original feature of ethtool which allows user to specify subset of
> tuple for setting up flow director.

Where is the interpretation of this special value defined in the
ethtool headers?

If it doesn't even have a macro for that magic constant value, it's
not part of the interface at all.

If the only other example of doing this trick is another Intel driver,
that lends even less credence to your arguments that this is a defined
interface.  Rather, it makes it look even more like an Intel specific
behavior.  Vendor specific behaviors of interfaces is exactly what we
are trying to avoid.