netdev - Re: [PATCH net 1/1] qede: prevent chip hang when increasing channels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160506.155158.1383422608405482582.davem@davemloft.net>
Date:	Fri, 06 May 2016 15:51:58 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	sudarsana.kalluru@...gic.com
Cc:	netdev@...r.kernel.org, Yuval.Mintz@...gic.com
Subject: Re: [PATCH net 1/1] qede: prevent chip hang when increasing
 channels

From: Sudarsana Reddy Kalluru <sudarsana.kalluru@...gic.com>
Date: Thu, 5 May 2016 00:35:16 -0400

> qede requires qed to provide enough resources to accommodate 16 combined
> channels, but that upper-bound isn't actually being enforced by it.
> Instead, qed inform back to qede how many channels can be opened based on
> available resources - but that calculation doesn't really take into account
> the resources requested by qede; Instead it considers other FW/HW available
> resources.
> 
> As a result, if a user would increase the number of channels to more than
> 16 [e.g., using ethtool] the chip would hang.
> 
> This change increments the resources requested by qede to 64 combined
> channels instead of 16; This value is an upper bound on the possible
> available channels [due to other FW/HW resources].
> 
> Signed-off-by: Sudarsana Reddy Kalluru <sudarsana.kalluru@...gic.com>
> Signed-off-by: Yuval Mintz <Yuval.Mintz@...gic.com>

Applied.