netdev - Re: [PATCH net-next] ipv4: tcp: ip_send_unicast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160506.160308.392258128417213365.davem@davemloft.net>
Date:	Fri, 06 May 2016 16:03:08 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org, andreslc@...gle.com, edumazet@...gle.com
Subject: Re: [PATCH net-next] ipv4: tcp: ip_send_unicast_reply() is not BH
 safe

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Fri, 06 May 2016 09:46:18 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> I forgot that ip_send_unicast_reply() is not BH safe (yet).
> 
> Disabling preemption before calling it was not a good move.
> 
> Fixes: c10d9310edf5 ("tcp: do not assume TCP code is non preemptible")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: Andres Lagar-Cavilla  <andreslc@...gle.com>

Applied, thanks.