netdev - Re: [PATCH v3 net-next 01/11] gso: Remove arbitrary checks for unsupported GSO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <572D1BE1.80702@gmail.com>
Date:	Fri, 6 May 2016 15:34:09 -0700
From:	Alexander Duyck <alexander.duyck@...il.com>
To:	Tom Herbert <tom@...bertland.com>, davem@...emloft.net,
	netdev@...r.kernel.org
Cc:	kernel-team@...com
Subject: Re: [PATCH v3 net-next 01/11] gso: Remove arbitrary checks for
 unsupported GSO

On 05/06/2016 03:11 PM, Tom Herbert wrote:
> In several gso_segment functions there are checks of gso_type against
> a seemingly arbitrary list of SKB_GSO_* flags. This seems like an
> attempt to identify unsupported GSO types, but since the stack is
> the one that set these GSO types in the first place this seems
> unnecessary to do. If a combination isn't valid in the first
> place that stack should not allow setting it.
>
> This is a code simplication especially for add new GSO types.
>
> Signed-off-by: Tom Herbert <tom@...bertland.com>
> ---
>   net/ipv4/af_inet.c     | 18 ------------------
>   net/ipv4/gre_offload.c | 14 --------------
>   net/ipv4/tcp_offload.c | 19 -------------------
>   net/ipv4/udp_offload.c | 10 ----------
>   net/ipv6/ip6_offload.c | 18 ------------------
>   net/ipv6/udp_offload.c | 13 -------------
>   net/mpls/mpls_gso.c    |  9 ---------
>   7 files changed, 101 deletions(-)
>

This is a nice clean-up since tunnels have essentially made things like 
trying to filter TSOV4 or TSOV6 pointless for the network layer.

Acked-by: Alexander Duyck <aduyck@...antis.com>