netdev - Re: [PATCH 1/2] net: phy: add ethtool_phy_{get|set}_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1462622397.19332.28.camel@decadent.org.uk>
Date:	Sat, 07 May 2016 12:59:57 +0100
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Philippe Reynes <tremyfr@...il.com>, f.fainelli@...il.com,
	fugang.duan@....com, davem@...emloft.net
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] net: phy: add ethtool_phy_{get|set}_link_ksettings

On Sat, 2016-05-07 at 01:18 +0200, Philippe Reynes wrote:
> The callback {get|set}_link_ksettings are often defined
> in a very close way. There are mainly two differences in
> those callback:
> - the name of the netdev private structure
> - the name of the struct phydev in the private structure
> 
> We add two defines ethtool_phy_{get|set}_link_ksettings
> to avoid writing severals times almost the same function.
[...]

I don't think there's no need to access a private structure, as there's
a phydev pointer in struct net_device.  If some drivers don't maintain
that pointer, they should be changed to do so.  Then they can 
use generic implementations of {get,set}_link_ksettings provided by
phylib.

Ben.

-- 
Ben Hutchings
Editing code like this is akin to sticking plasters on the bleeding stump
of a severed limb. - me, 29 June 1999
Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)