netdev - Re: [PATCH net-next 1/2] net: l3mdev: Move get_saddr and rt6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160507.150114.1039727169335366513.davem@davemloft.net>
Date:	Sat, 07 May 2016 15:01:14 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	dsa@...ulusnetworks.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next 1/2] net: l3mdev: Move get_saddr and rt6_dst

From: David Ahern <dsa@...ulusnetworks.com>
Date: Wed,  4 May 2016 21:54:09 -0700

> +		if (dev && netif_is_l3_master(dev) &&
> +		    dev->l3mdev_ops->l3mdev_get_saddr) {
> +			rc = dev->l3mdev_ops->l3mdev_get_saddr(dev, fl4);
> +		}

Please do not use braces for single statement basic blocks.

The same issue exists in patch #2 so please fix it there as well.

Thanks.