netdev - Re: [PATCH net-next 2/4] xen-netback: add control protocol implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160507.150921.2053537729453518863.davem@davemloft.net>
Date:	Sat, 07 May 2016 15:09:21 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	paul.durrant@...rix.com
Cc:	xen-devel@...ts.xenproject.org, netdev@...r.kernel.org,
	wei.liu2@...rix.com
Subject: Re: [PATCH net-next 2/4] xen-netback: add control protocol
 implementation

From: Paul Durrant <paul.durrant@...rix.com>
Date: Thu, 5 May 2016 12:19:28 +0100

> +struct xenvif_hash_cache {
> +	rwlock_t lock;

You really don't want to lock on every SKB hash computation like
this, turn this into a spin lock for locking the write side and
use RCU locking for lookup and usage.

THanks.