netdev - Re: [PATCHv2 bluetooth-next 08/10] ipv6: export ndisc functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bc3b76cc-c37c-53ab-4a1e-31212eab6dbe@pengutronix.de>
Date:	Sun, 8 May 2016 12:46:27 +0200
From:	Alexander Aring <aar@...gutronix.de>
To:	Hannes Frederic Sowa <hannes@...essinduktion.org>,
	linux-wpan@...r.kernel.org
Cc:	kernel@...gutronix.de, marcel@...tmann.org,
	jukka.rissanen@...ux.intel.com, stefan@....samsung.com,
	mcr@...delman.ca, werner@...esberger.net,
	linux-bluetooth@...r.kernel.org, netdev@...r.kernel.org,
	"David S . Miller" <davem@...emloft.net>,
	Alexey Kuznetsov <kuznet@....inr.ac.ru>,
	James Morris <jmorris@...ei.org>,
	Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
	Patrick McHardy <kaber@...sh.net>
Subject: Re: [PATCHv2 bluetooth-next 08/10] ipv6: export ndisc functions


Hi,

On 05/02/2016 09:39 PM, Hannes Frederic Sowa wrote:
> On 20.04.2016 10:19, Alexander Aring wrote:
>> This patch exports some neighbour discovery functions which can be used
>> by 6lowpan neighbour discovery ops functionality then.
>>
>> Cc: David S. Miller <davem@...emloft.net>
>> Cc: Alexey Kuznetsov <kuznet@....inr.ac.ru>
>> Cc: James Morris <jmorris@...ei.org>
>> Cc: Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>
>> Cc: Patrick McHardy <kaber@...sh.net>
>> Signed-off-by: Alexander Aring <aar@...gutronix.de>
>> ---
>>  include/net/ndisc.h | 16 ++++++++++++++++
>>  net/ipv6/addrconf.c |  1 +
>>  net/ipv6/ndisc.c    | 28 ++++++++++------------------
>>  3 files changed, 27 insertions(+), 18 deletions(-)
>>
>> diff --git a/include/net/ndisc.h b/include/net/ndisc.h
>> index 14ed016..35a4396 100644
>> --- a/include/net/ndisc.h
>> +++ b/include/net/ndisc.h
>> @@ -53,6 +53,15 @@ enum {
>>  
>>  #include <net/neighbour.h>
>>  
>> +/* Set to 3 to get tracing... */
>> +#define ND_DEBUG 1
>> +
>> +#define ND_PRINTK(val, level, fmt, ...)				\
>> +do {								\
>> +	if (val <= ND_DEBUG)					\
>> +		net_##level##_ratelimited(fmt, ##__VA_ARGS__);	\
>> +} while (0)
>> +
> 
> If the debug messages are well thought out, I think we could install
> them always on debug level.
> 
> There are valid users now, so
> 

Not sure if I understand you correctly here. Is this patch is fine or I
should remove ND_DEBUG, because it's handled by "net_##level##_ratelimited"
and the debug level will be handled then by other debug level settings
then?

Thanks.

- Alex