netdev - Re: [net-next PATCH V1 3/3] net: warn on napi_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b9f06970-686d-e04d-7620-94e085238456@cogentembedded.com>
Date:	Mon, 9 May 2016 16:53:41 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Jesper Dangaard Brouer <brouer@...hat.com>, netdev@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>
Cc:	saeedm@...lanox.com, gerlitz.or@...il.com, eugenia@...lanox.com,
	Alexander Duyck <alexander.duyck@...il.com>
Subject: Re: [net-next PATCH V1 3/3] net: warn on napi_alloc_skb being called
 in wrong context

Hello.

On 5/9/2016 4:44 PM, Jesper Dangaard Brouer wrote:

> It have always been required to call napi_alloc_skb from NAPI/softirq

    It has.

> context, which implies running with local_bh_disable'ed.  Thus, this

    Not local_bh_disable'd?

> code path should already be well tested. But recent SKB bulk changes
> introduced will make this more volatile and bugs more subtle, if this
> is violated.
>
> To catch any driver violating this add a loud WARN_ON.
>
> Performance wise, I do worry about adding this runtime check code into
> the hotpath, of this highly optimized function call.  I've

    Hot path? My spellchecked trips here.

> micro-benchmarked it with both IP-forwarding and local UDP delivery,
> and didn't see any regressions.  It does adds extra code size (icache).
>
> add/remove: 0/0 grow/shrink: 1/0 up/down: 43/0 (43)
> function                                     old     new   delta
> __napi_alloc_skb                             461     504     +43
>
> Signed-off-by: Jesper Dangaard Brouer <brouer@...hat.com>
[...]

MBR, Sergei