netdev - Re: [PATCH net-next v2 00/21] net: dsa: mv88e6xxx: turn into monolithic driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160509.150059.1262002047956591909.davem@davemloft.net>
Date:	Mon, 09 May 2016 15:00:59 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	andrew@...n.ch
Cc:	vivien.didelot@...oirfairelinux.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel@...oirfairelinux.com,
	f.fainelli@...il.com
Subject: Re: [PATCH net-next v2 00/21] net: dsa: mv88e6xxx: turn into
 monolithic driver

From: Andrew Lunn <andrew@...n.ch>
Date: Mon, 9 May 2016 19:56:47 +0200

> On Mon, May 09, 2016 at 01:22:37PM -0400, Vivien Didelot wrote:
>> This patchset merges all mv88e6* drivers supported by the shared
>> mv88e6xxx code into a single mv88e6xxx DSA switch driver.
>> 
>> Some flags are added to describe the capabilities of a switch model,
>> such as the presence of a PPU, EEPROM, some old or new registers, etc.
>> 
>> First these flags are used to conditionally support the same set of
>> functions in every driver, then specific driver files are removed in
>> favor of the common mv88e6xxx driver.
>> 
>> Only the merge of driver specific setup code assumes a few differences.
>> If these differences such as frames priorities are really needed for
>> some models, they can easily be brought back in a future patch.
>> 
>> Some inconsistencies might show up, such as the need for
>> MV88E6XXX_FLAG_PPU and MV88E6XXX_FLAG_PPU_ACTIVE flags. But this
>> patchset does not aim to fix them yet. A future patch can do that if
>> they end up being unwanted.
>> 
>> The patchset has been tested on interconnected 88E6352 and 88E6185.
> 
> Reviewed-by: Andrew Lunn <andrew@...n.ch>
> 
> I also tested v1, so
> 
> Tested-by: Andrew Lunn <andrew@...n.ch>

Series applied, thanks everyone.