netdev - Re: [net-next PATCH v2 5/6] net sched: skbedit action fix late binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57307A47.9090307@mojatatu.com>
Date:	Mon, 9 May 2016 07:53:43 -0400
From:	Jamal Hadi Salim <jhs@...atatu.com>
To:	Cong Wang <xiyou.wangcong@...il.com>
Cc:	David Miller <davem@...emloft.net>,
	Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: Re: [net-next PATCH v2 5/6] net sched: skbedit action fix late
 binding

On 16-05-08 11:28 PM, Cong Wang wrote:

>> +       /* if action exists and this is a late filter bind, no need
>> +        * to continue processing
>> +       */
>
> This comment looks useless, at least for me, because the code
> is already clear.
>

I will get rid of it. Note: I added it to one patch only incase
the feature of late binding was foreign to some people.

>
>> +       if (aexists && bind)
>> +                       return 0;
>
>
> One extra tab?
>

thanks for catching it.

cheers,
jamal