lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20160509131547.GX16459@soda.linbit> Date: Mon, 9 May 2016 15:15:48 +0200 From: Lars Ellenberg <lars.ellenberg@...bit.com> To: Nicolas Dichtel <nicolas.dichtel@...nd.com> Cc: davem@...emloft.net, netdev@...r.kernel.org, philipp.reisner@...bit.com, drbd-dev@...ts.linbit.com, linux-kernel@...r.kernel.org Subject: Re: [PATCH net-next v3] block/drbd: align properly u64 in nl messages On Mon, May 09, 2016 at 11:40:20AM +0200, Nicolas Dichtel wrote: > The attribute 0 is never used in drbd, so let's use it as pad attribute > in netlink messages. This minimizes the patch. > > Note that this patch is only compile-tested. > > Signed-off-by: Nicolas Dichtel <nicolas.dichtel@...nd.com> > Signed-off-by: Lars Ellenberg <lars.ellenberg@...bit.com> > --- > > v2 -> v3: > use 0 as padattr instead of adding new attributes Thanks. > v1 -> v2: > rework the patch to handle all cases > > Maybe prefixing genl_magic_func.h and genl_magic_struct.h by 'drbd_' > could be interesting so that new module won't use it. What is your > opinion? This was supposed to not be DRBD specific. But it might even still need some massaging before it was truly generic. And obviously, it does not meet the taste of genetlink folks, to say the least :( I don't care either way. Lars Ellenberg
Powered by blists - more mailing lists