netdev - Re: [PATCH 2/7] net: ircomm, cleanup TIOCGSERIAL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160510.141615.174614051833919078.davem@davemloft.net>
Date:	Tue, 10 May 2016 14:16:15 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	jslaby@...e.cz
Cc:	gregkh@...uxfoundation.org, linux-serial@...r.kernel.org,
	linux-kernel@...r.kernel.org, samuel@...tiz.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH 2/7] net: ircomm, cleanup TIOCGSERIAL

From: Jiri Slaby <jslaby@...e.cz>
Date: Mon,  9 May 2016 09:11:54 +0200

> In ircomm_tty_get_serial_info, struct serial_struct is memset to 0 and
> then some members set to 0 explicitly.
> 
> Remove the latter as it is obviously superfluous.
> 
> And remove the retinfo check against NULL. copy_to_user will take care
> of that.
> 
> Part of hub6 cleanup series.
> 
> Signed-off-by: Jiri Slaby <jslaby@...e.cz>

Acked-by: David S. Miller <davem@...emloft.net>