netdev - Re: [PATCH v2 net-next] tcp: replace cnt & rtt with struct in pkts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160510.150047.1472901479981953800.davem@davemloft.net>
Date:	Tue, 10 May 2016 15:00:47 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	brakmo@...com
Cc:	netdev@...r.kernel.org, kernel-team@...com, ncardwell@...gle.com,
	eric.dumazet@...il.com, ycheng@...gle.com
Subject: Re: [PATCH v2 net-next] tcp: replace cnt & rtt with struct in
 pkts_acked()

From: Lawrence Brakmo <brakmo@...com>
Date: Mon, 9 May 2016 14:46:12 -0700

> @@ -197,15 +197,15 @@ static void bictcp_state(struct sock *sk, u8 new_state)
>  /* Track delayed acknowledgment ratio using sliding window
>   * ratio = (15*ratio + sample) / 16
>   */
> -static void bictcp_acked(struct sock *sk, u32 cnt, s32 rtt)
> +static void bictcp_acked(struct sock *sk, const struct ack_sample *sample)
>  {
>  	const struct inet_connection_sock *icsk = inet_csk(sk);
>  
>  	if (icsk->icsk_ca_state == TCP_CA_Open) {
>  		struct bictcp *ca = inet_csk_ca(sk);
>  
> -		cnt -= ca->delayed_ack >> ACK_RATIO_SHIFT;
> -		ca->delayed_ack += cnt;
> +		ca->delayed_ack += sample->pkts_acked - 

^^ Trailing whitespace on that line.

> +		struct ack_sample sample = {.pkts_acked = pkts_acked,
> +					    .rtt_us = ca_rtt_us};

Please put a space after the openning parenthesis and before the closing parenthesis.