netdev - ax88179_178a: disabled FLAG_MULTI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CA+vmRF7Rb9HqCjCW84YEqofBDTcsst89BU=zX=Y5fMCeXbP+KA@mail.gmail.com>
Date:	Tue, 10 May 2016 13:05:28 +0530
From:	Vivek Bhagat <vivek.bhagat89@...il.com>
To:	netdev@...r.kernel.org
Subject: ax88179_178a: disabled FLAG_MULTI_PACKET

Hi,

ax88179_178a_rx_fixup() function is cloning the data and calling
usbnet_skb_return(). Since FLAG_MULTI_PACKET is not set,
usbnet_skb_return() is being called second time within rx_process()
function in usbnet.c.

I simply enabled the flag in ax88179_info as below -
    .flags = FLAG_ETHER..| FLAG_MULTI_PACKET

Ping stops working.

Could anyone please point out what could be the reason behind sending
same packets 2 times to upper layer (from usbnet and its class driver
ax88179_178a)?

In case of asix 2.0 driver, avove flag is set and it is working.

Thanks,
Vivek