netdev - Re: [PATCH net-next] fjes: Fix unnecessary spinlock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8e0d4e29-30b4-af2d-733f-4cf9d229237c@cogentembedded.com>
Date:	Tue, 10 May 2016 16:13:41 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Taku Izumi <izumi.taku@...fujitsu.com>, netdev@...r.kernel.org,
	davem@...emloft.net
Cc:	isimatu.yasuaki@...fujitsu.com
Subject: Re: [PATCH net-next] fjes: Fix unnecessary spinlock_irqsave

Hello.

On 5/10/2016 4:28 AM, Taku Izumi wrote:

> commit-bd5a256 introduces a deadlock bug in fjes_change_mtu().

    scripts/checkpatch.pl now enforces a certain commit citing style, yours 
doesn't match it.

> This spin_lock_irqsave() is obviously unnecessary.
>
> This patch eliminates unnecessary spin_lock_irqsave() in
> fjes_change_mtu()
>
> Signed-off-by: Taku Izumi <izumi.taku@...fujitsu.com>
[...]

    The "Fixes:" tag would also be in order...

MBR, Sergei