netdev - Re: [PATCH net] gre: do not keep the GRE header around in collect medata mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160511.151741.532292838636551403.davem@davemloft.net>
Date:	Wed, 11 May 2016 15:17:41 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	jbenc@...hat.com
Cc:	netdev@...r.kernel.org, pshelar@....org, simon.horman@...ronome.com
Subject: Re: [PATCH net] gre: do not keep the GRE header around in collect
 medata mode

From: Jiri Benc <jbenc@...hat.com>
Date: Wed, 11 May 2016 15:53:57 +0200

> For ipgre interface in collect metadata mode, it doesn't make sense for the
> interface to be of ARPHRD_IPGRE type. The outer header of received packets
> is not needed, as all the information from it is present in metadata_dst. We
> already don't set ipgre_header_ops for collect metadata interfaces, which is
> the only consumer of mac_header pointing to the outer IP header.
> 
> Just set the interface type to ARPHRD_NONE in collect metadata mode for
> ipgre (not gretap, that still correctly stays ARPHRD_ETHER) and reset
> mac_header.
> 
> Fixes: a64b04d86d14 ("gre: do not assign header_ops in collect metadata mode")
> Fixes: 2e15ea390e6f4 ("ip_gre: Add support to collect tunnel metadata.")
> Signed-off-by: Jiri Benc <jbenc@...hat.com>

Applied, thanks Jiri.