netdev - Re: [PATCH nf-next,v2] gtp: add initial driver for datapath of GPRS Tunneling Protocol (GTP-U)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAM_iQpX+KDStq7cdW=YLpRUS-xceXbn8yW52ia1fwagiUBXr2Q@mail.gmail.com>
Date:	Tue, 10 May 2016 22:24:56 -0700
From:	Cong Wang <xiyou.wangcong@...il.com>
To:	Pablo Neira Ayuso <pablo@...filter.org>
Cc:	Linux Kernel Network Developers <netdev@...r.kernel.org>,
	David Miller <davem@...emloft.net>, laforge@...monks.org,
	aschultz@...p.net, openbsc@...ts.osmocom.org
Subject: Re: [PATCH nf-next,v2] gtp: add initial driver for datapath of GPRS
 Tunneling Protocol (GTP-U)

On Sun, May 8, 2016 at 3:55 PM, Pablo Neira Ayuso <pablo@...filter.org> wrote:
> +static int gtp_genl_new_pdp(struct sk_buff *skb, struct genl_info *info)
> +{
...
> +
> +       net = gtp_genl_get_net(sock_net(skb->sk), info->attrs);
> +       if (IS_ERR(net))
> +               return PTR_ERR(net);
> +
> +       /* Check if there's an existing gtpX device to configure */
> +       dev = gtp_find_dev(net, nla_get_u32(info->attrs[GTPA_LINK]));
> +       if (dev == NULL)
> +               return -ENODEV;
> +
> +       return ipv4_pdp_add(dev, info);


Seems you are leaking struct net at least in the error path.