netdev - Re: [PATCH -next 3/4] net: w5100: increase TX timeout period

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAC5umyguwoKbOeNUjx_BH0=Aj5WdJoQan0p6LJppObsSw3Wd1g@mail.gmail.com>
Date:	Thu, 12 May 2016 19:50:39 +0900
From:	Akinobu Mita <akinobu.mita@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev <netdev@...r.kernel.org>,
	Mike Sinkovsky <msink@...monline.ru>
Subject: Re: [PATCH -next 3/4] net: w5100: increase TX timeout period

2016-05-12 8:49 GMT+09:00 David Miller <davem@...emloft.net>:
> From: Akinobu Mita <akinobu.mita@...il.com>
> Date: Wed, 11 May 2016 15:30:26 +0900
>
>> This increases TX timeout period from one second to 5 seconds which is
>> default value defined in net/sched/sch_generic.c.
>>
>> The one second timeout is too short for W5100 with SPI interface mode
>> which doesn't support burst READ/WRITE processing in the SPI transfer.
>> If the packet is transmitted while RX packets are being received at a
>> very high rate, the TX transmittion work in the workqueue is delayed
>> and the watchdog timer is expired.
>>
>> Signed-off-by: Akinobu Mita <akinobu.mita@...il.com>
>
> It would be just cleaner to just remove the assignment completely, and
> let said net/sched/sch_generic.c code set the default for you.

Sounds good.  I'll resubmit the series with that change.