lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Thu, 12 May 2016 16:48:04 +0200
From:	Jiri Pirko <jiri@...nulli.us>
To:	Andrew Lunn <andrew@...n.ch>
Cc:	netdev@...r.kernel.org, davem@...emloft.net, nogahf@...lanox.com,
	idosch@...lanox.com, eladr@...lanox.com, yotamg@...lanox.com,
	ogerlitz@...lanox.com, roopa@...ulusnetworks.com,
	nikolay@...ulusnetworks.com, linville@...driver.com, tgraf@...g.ch,
	gospo@...ulusnetworks.com, sfeldma@...il.com, sd@...asysnail.net,
	eranbe@...lanox.com, ast@...mgrid.com, edumazet@...gle.com,
	hannes@...essinduktion.org
Subject: Re: [patch net-next 0/4] return offloaded stats as default and
 expose original sw start

Thu, May 12, 2016 at 04:36:45PM CEST, andrew@...n.ch wrote:
>On Thu, May 12, 2016 at 11:59:54AM +0200, Jiri Pirko wrote:
>> From: Jiri Pirko <jiri@...lanox.com>
>> 
>> Until now we had stats functions return SW statistics. However, it makes
>> a lot of sense to return HW stats as default.
>
>Hi Jiri
>
>DSA has always returned the HW stats, i.e, ethtool -S shows the
>counters the switch has for the port.
>
>How do you expect ethtool to handle your change? ethtool -S will print
>both sets? Or are you thinking of adding a new flag?

Ethtool still continues to provide the hw counters. We do the same for
mlxsw driver. No change there.

>
>I'm just trying to understand the big picture, and how it affects DSA,
>if at all.

I didn't check the code, but if dsa provides sw stats by default, it
should be changed to provide hwstats instead. The goal is to keep the
existing applications to see what is going on.

Powered by blists - more mailing lists