netdev - Re: [PATCH net-next] sunrpc: set SOCK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160513.014618.367967738394775604.davem@davemloft.net>
Date:	Fri, 13 May 2016 01:46:18 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	jiri@...nulli.us, edumazet@...gle.com, netdev@...r.kernel.org,
	ying.huang@...el.com
Subject: Re: [PATCH net-next] sunrpc: set SOCK_FASYNC

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Thu, 12 May 2016 21:41:39 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> sunrpc is using SOCKWQ_ASYNC_NOSPACE without setting SOCK_FASYNC,
> so the recent optimizations done in sk_set_bit() and sk_clear_bit()
> broke it.
> 
> There is still the risk that a subsequent sock_fasync() call
> would clear SOCK_FASYNC, but sunrpc does not use this yet.
> 
> Fixes: 9317bb69824e ("net: SOCKWQ_ASYNC_NOSPACE optimizations")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: Jiri Pirko <jiri@...nulli.us>
> Reported-by: Huang, Ying <ying.huang@...el.com>
> Tested-by: Jiri Pirko <jiri@...nulli.us>
> Tested-by: Huang, Ying <ying.huang@...el.com>

Applied, thanks.