| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <573619C8.2040905@gmail.com> Date: Fri, 13 May 2016 11:15:36 -0700 From: John Fastabend <john.fastabend@...il.com> To: Sridhar Samudrala <sridhar.samudrala@...el.com>, john.r.fastabend@...el.com, netdev@...r.kernel.org Subject: Re: [PATCH v2 net-next 2/2] net: cls_u32: Add support for skip-sw flag to tc u32 classifier. On 16-05-12 05:08 PM, Sridhar Samudrala wrote: > On devices that support TC U32 offloads, this flag enables a filter to be > added only to HW. skip-sw and skip-hw are mutually exclusive flags. By > default without any flags, the filter is added to both HW and SW, but no > error checks are done in case of failure to add to HW. With skip-sw, > failure to add to HW is treated as an error. > > Here is a sample script that adds 2 filters, one with skip-sw and the other > with skip-hw flag. > > # add ingress qdisc > tc qdisc add dev p4p1 ingress > > # enable hw tc offload. > ethtool -K p4p1 hw-tc-offload on > > # add u32 filter with skip-sw flag. > tc filter add dev p4p1 parent ffff: protocol ip prio 99 \ > handle 800:0:1 u32 ht 800: flowid 800:1 \ > skip-sw \ > match ip src 192.168.1.0/24 \ > action drop > > # add u32 filter with skip-hw flag. > tc filter add dev p4p1 parent ffff: protocol ip prio 99 \ > handle 800:0:2 u32 ht 800: flowid 800:2 \ > skip-hw \ > match ip src 192.168.2.0/24 \ > action drop > > Signed-off-by: Sridhar Samudrala <sridhar.samudrala@...el.com> > --- Looks good to me thanks for doing this. Acked-by: John Fastabend <john.r.fastabend@...el.com>
Powered by blists - more mailing lists